Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune CSS classes from output that are not used #84

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Prune CSS classes from output that are not used #84

merged 2 commits into from
Apr 2, 2018

Conversation

cfstras
Copy link
Contributor

@cfstras cfstras commented Mar 29, 2018

This only outputs CSS classes that are actually being used, enabling usage in emails.

Many email providers, such as GMail, drop style large segments -- if we only output what is actually necessary, we get around that nicely.

@ralphbean
Copy link
Collaborator

Nice idea!

Can you fix the test suite before we merge?

@cfstras
Copy link
Contributor Author

cfstras commented Mar 31, 2018

Does that suit?

Copy link
Collaborator

@ralphbean ralphbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thank you!

@ralphbean ralphbean merged commit e942b16 into pycontribs:develop Apr 2, 2018
@cfstras
Copy link
Contributor Author

cfstras commented Apr 2, 2018

👌

@cfstras cfstras deleted the prune-unused-css branch February 12, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants