Fixes and improvements #864
Open
+54
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin should be downloaded from
for more information, see https://pre-commit.ci
|
I reuse someone else's comment that lead to updates: Some feedback so we can integrate, or discuss, on this ? |
Achimh3011
approved these changes
Jan 9, 2025
| not hasattr(self, "_get_plugins") | ||
| or self._get_plugins.baseurl != url | ||
| ): | ||
| self._get_plugins = Plugins(url, self) |
There was a problem hiding this comment.
I'd prefer something like self._plugin_cache to make it clear that it is data and not a method.
| update_center = ( | ||
| "https://updates.jenkins.io/update-center.actual.json" | ||
| ) | ||
| jsonp = requests.get(update_center).content.decode("utf-8") |
There was a problem hiding this comment.
Why not directly use the json() method on the response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please find here some improvements added to this, very good, library.
In order to use it efficiently and correctly, I had to integrate these updates.
I cherry-picked (to give credit to @mrrsm) the commit added in this PR.
I hope this can be merged, so I can switch to the real release, instead of my own repo.