Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.py #1005

Merged
merged 2 commits into from
May 12, 2021
Merged

Update client.py #1005

merged 2 commits into from
May 12, 2021

Conversation

EdgeSync
Copy link
Contributor

@EdgeSync EdgeSync commented Mar 10, 2021

Change made to solve warning in JIRA when adding an attachment.

Error:
2021-03-10 17:18:20,564+0000 https-jsse-nio-8443-exec-98 WARN ***REDACTED*** 1038x776292x1 1pqrv0m 16.85.88.14 /rest/api/2/issue/GIA-3259/attachments [c.a.p.r.c.security.jersey.XsrfResourceFilter] Use of the 'nocheck' value for X-Atlassian-Token has been deprecated since rest 3.0.0. Please use a value of 'no-check' instead.

Solution:
Edit client.py and change both instances of nocheck to no-check

Chance made to solve error:

    c.a.p.r.c.security.jersey.XsrfResourceFilter] Use of the 'nocheck' value for X-Atlassian-Token has been deprecated since rest 3.0.0. Please use a value of 'no-check' instead.
@studioj
Copy link
Collaborator

studioj commented Apr 4, 2021

Chance made to solve warning in JIRA when adding an attachment.

Error:
2021-03-10 17:18:20,564+0000 https-jsse-nio-8443-exec-98 WARN ***REDACTED*** 1038x776292x1 1pqrv0m 16.85.88.14 /rest/api/2/issue/GIA-3259/attachments [c.a.p.r.c.security.jersey.XsrfResourceFilter] Use of the 'nocheck' value for X-Atlassian-Token has been deprecated since rest 3.0.0. Please use a value of 'no-check' instead.

Solution:
Edit client.py and chance both instances of nocheck to no-check

looks like the maintainers want to have the ci system back up and running before agreeing to any new merges.

if you want to contribute to get yr pr through have a look here => #896

@adehad adehad added the bug label May 2, 2021
@studioj
Copy link
Collaborator

studioj commented May 7, 2021

@EdgeSync please make sure latest master changes are in your branch so the CI system can run again.
the change seems to be a valid one

@EdgeSync
Copy link
Contributor Author

EdgeSync commented May 7, 2021

@EdgeSync please make sure latest master changes are in your branch so the CI system can run again.
the change seems to be a valid one

hey @studioj - i've done a fetch upstream, and merged on my fork. Hope that's what you mean.

@studioj studioj closed this May 7, 2021
@studioj studioj reopened this May 7, 2021
@studioj
Copy link
Collaborator

studioj commented May 7, 2021

Was hoping to see the CI triggered. Now I'm wondering if it was the close reopen which triggered it properly...
Anyway it's running 👍

@studioj
Copy link
Collaborator

studioj commented May 12, 2021

@ssbarnea seems like a valid change ready to merge

@ssbarnea ssbarnea merged commit ae6b746 into pycontribs:master May 12, 2021
svermeulen pushed a commit to svermeulen/jira that referenced this pull request Oct 31, 2021
Chance made to solve error:

    c.a.p.r.c.security.jersey.XsrfResourceFilter] Use of the 'nocheck' value for X-Atlassian-Token has been deprecated since rest 3.0.0. Please use a value of 'no-check' instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants