[feature] Add support for requests timeout #1574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the timeout parameter when performing HTTP request and fix some comments/typing related to the timeout parameter.
Jira is based on the python requests library to perform HTTP requests so we can use its timeout parameter as explained here : https://requests.readthedocs.io/en/latest/user/advanced/#timeouts
I think this library planed to do so, but it was not implemented.
The timeout parameter still has a None default value so no change is expected on applications which don't set a timeout value. For other applications who though they were using it then it will start to work.