Update the type for issue in add_comment & transition_issue for better type hints #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dvaerum, could you rebase and see if this fixes the any issues. Also a reminder to update the docstrings ! |
dvaerum
force-pushed
the
add_more_type_hints
branch
3 times, most recently
from
ab61918
to
2b8f8c4
Compare
dvaerum
force-pushed
the
add_more_type_hints
branch
from
2b8f8c4
to
2feaab9
Compare
Done, but I am not certain why ci/cloud/py3.8 fails |
adehad
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that these 2 function works with both the type "str" and "ISSUE" because whatever one adds as the issue argument is converted to a string, and when the class Issue is converted to a string it returns the issue-key.
So, this should give better type hinting, and I am sure there are more place in the code this scenario exists 😄