Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sprint goal #1586

Conversation

mohit2152sharma
Copy link

The method update_sprint doesn't allow to update the sprint goal, as it is not included in method's parameter. Simply adding goal into function's argument, just like other arguments (e.g. name, endDate, startDate) fixes that.

Copy link
Collaborator

@studioj studioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this.
please add a testcase validating this change

@mohit2152sharma
Copy link
Author

I couldn't find test cases for update_sprint() function, I was thinking to modify that to include this scenario, could you direct me to the respective section if it exists?

@studioj
Copy link
Collaborator

studioj commented Feb 28, 2023

I couldn't find test cases for update_sprint() function, I was thinking to modify that to include this scenario, could you direct me to the respective section if it exists?

maybe have a look here
https://github.com/pycontribs/jira/blob/main/tests/resources/test_sprint.py
also have a look at possible conflicts => we did a lot of docstring cleaning

@adehad
Copy link
Contributor

adehad commented Mar 25, 2024

Thanks for starting this PR @mohit2152sharma ! We have now merged in a PR that took inspiration from your work #1806

@adehad adehad closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants