Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make create_issue_link work with issue_link-objects #1621

Merged

Conversation

rynkk
Copy link
Contributor

@rynkk rynkk commented Mar 8, 2023

Base fix

fixes #1604

The program was tested solely for our own use cases, which might differ from yours.


Jannik Meinecke jannik.meinecke@mercedes-benz.com on behalf of MBition GmbH.
https://github.com/mercedes-benz/foss/blob/master/PROVIDER_INFORMATION.md

Licensed under BSD-2-Clause license

fixes pycontribs#1604

The program was tested solely for our own use cases, which might differ from yours.
___
Jannik Meinecke <jannik.meinecke@mercedes-benz.com> on behalf of MBition GmbH.
https://github.com/mercedes-benz/foss/blob/master/PROVIDER_INFORMATION.md

Licensed under [BSD-2-Clause license](https://github.com/pycontribs/jira/blob/main/LICENSE)</sub>
@rynkk
Copy link
Contributor Author

rynkk commented Mar 8, 2023

The only thing that is still annoying me are the type hints of the functions wrapped by translate_resource_args-decorator.
Should they be modified to match to their wrapped functionality or is there a way to statically change the type hints using the decorator?


Jannik Meinecke (jannik.meinecke@mercedes-benz.com) on behalf of MBition GmbH.
Provider Information

@adehad adehad added the feature label Mar 11, 2023
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have problems with that decorator, I'm not sure the best answer at this stage as I haven't spent much time looking into the alternatives. But my initial gut preference would be for it to not exist.

@adehad adehad added bug and removed feature labels Mar 11, 2023
@adehad adehad merged commit 06a9a9e into pycontribs:main Mar 11, 2023
@adehad
Copy link
Contributor

adehad commented Mar 11, 2023

Thanks again for the great quality PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIRA.create_issue_link crash when passing IssueLinkType
2 participants