Create token auth option

[skaiaa]

I've implemented token based auth by adding proper class inheriting from AuthBase and adding basic_auth parameter to constructor. Results in adding header in form: "authorization" : "Bearer <token>".

[studioj]

@skaiaa you think it would be possible to test this implementation on jira server?
Ci atm only tests jira server and it would be a nice addition to the rest of the test suite.
Dunno exactly how to handle auth stuff but the jira server instance is a fresh install for each CI run

[skaiaa]

@studioj I tested the change manually with our automation scripts with Jira. Im not familiar with this repo, I can see only those tests: https://github.com/pycontribs/jira/blob/master/tests/tests.py and the file looks massive and scary - what is a proper process for adding unit/integration tests to the repo?

[studioj]

@studioj I tested the change manually with our automation scripts with Jira. Im not familiar with this repo, I can see only those tests: https://github.com/pycontribs/jira/blob/master/tests/tests.py and the file looks massive and scary - what is a proper process for adding unit/integration tests to the repo?

Great!
I'm not a tox expert refering to @adehad for this
As a minimum run tox -e lint to find the issues with the current lint test in ci.
I think running tox -e test will run the tests locally for you.
@adehad extended the readme to get started with local execution. If you feel there is improvement needed you could always extend the readme :-).

For testing oauth I was just wondering if it's possible for it to be tested on a local fresh install of jira server keeping in mind security and privacy

[adehad]

@skaiaa I completely agree that the tests.py is scary.

If I may suggest we make a new file called test_auth.py in the tests folder where we add a test?

As @studioj mentioned, we use tox in our CI, this is paired with docker container that runs a Jira Server instance we test against.
A quickstart may be found here:
https://github.com/pycontribs/jira/blob/master/README.rst#development

The Jira url is stored in the environment variable CI_JIRA_URL, you can also find the user's available in the CI test as environment variables:
https://github.com/pycontribs/jira/blob/master/tox.ini#L44

As the Jira instance is created fresh each time, I'm not sure how best we would get the auth token unless it remains constant. Happy to try and figure that out with you, maybe we might need to get a bit creative!

[adehad]

Looks like we can use the REST API to generate a PAT:

https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html#UsingPersonalAccessTokens-CreatingPATsusingRESTAPI

(@skaiaa could you maybe add me as a collaborator on your fork? I can try and help directly on that branch)

[skaiaa]

@adehad Sure I will add you and we can work on this together. Sorry for not responsiveness, pretty crazy week at work, let's get this done in upcoming week.

[adehad]

@skaiaa no worries, no pressure ! We all have stuff going on !

[studioj]

Hey @skaiaa any news ? :-) it seems that @adehad bumped the jira server version in our CI system

[adehad]

@ametzger can you give this branch a whirl and see if it works for you?