Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new post: add 2023 sponsor cathay post #56

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

kevin1kevin1k
Copy link
Contributor

@kevin1kevin1k kevin1kevin1k commented Oct 24, 2023

Types of changes

  • new post

Description

Add a new post for platinum sponsor Cathay of PyCon TW 2023
Original draft at google docs

@kevin1kevin1k kevin1kevin1k requested a review from a team as a code owner October 24, 2023 07:10
@kevin1kevin1k kevin1kevin1k force-pushed the new-post/2023-sponsor-cathay-post branch from ffa0ae1 to a877500 Compare October 24, 2023 07:25

| 公司 | 職缺 | 連結 | | |
|---------------------|------------------------------------------------|---------------------------------------------------------------|---|---|
| 國泰金控DDT | 資料科學工程師(Python程式開發) | <a href="https://www.104.com.tw/job/6w7ov" target="_blank">https://www.104.com.tw/job/6w7ov</a> | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why we don't use []() syntax for links here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this! Will fix this soon.

@Lee-W Lee-W assigned Lee-W and kevin1kevin1k and unassigned Lee-W Nov 6, 2023
@kevin1kevin1k kevin1kevin1k force-pushed the new-post/2023-sponsor-cathay-post branch from e2ed178 to 9b99843 Compare November 9, 2023 15:56
@kevin1kevin1k kevin1kevin1k force-pushed the new-post/2023-sponsor-cathay-post branch from 9b99843 to 52b64ae Compare November 9, 2023 15:58
@kevin1kevin1k kevin1kevin1k requested a review from Lee-W November 9, 2023 16:09
@Lee-W Lee-W requested review from 9ukei, a team and winniepopu November 17, 2023 02:03
Copy link
Contributor

@winniepopu winniepopu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@@ -0,0 +1,48 @@
Title: PyCon Taiwan 2023 贊助商 國泰金控 Cathay Financial Holdings
Date: 2023-11-12 21:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Date: 2023-11-12 21:00
Date: 2023-11-20 21:00

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just resolved my comments on my side. @kevin1kevin1k Thanks for helping out.

@Lee-W Lee-W merged commit 8691c53 into pycontw:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants