Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applause feature #68

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Add applause feature #68

merged 3 commits into from
Dec 22, 2023

Conversation

winniepopu
Copy link
Contributor

Types of changes

  • theme
  • config

Description

  • Add applause feature to article page
  • Support multiple claps
拍手demo照

@winniepopu winniepopu requested a review from a team as a code owner December 19, 2023 16:33
pelicanconf.py Outdated
@@ -66,6 +66,8 @@
THEME = "theme/Flex"
PLUGINS = ["i18n_subsites"]
PYGMENTS_STYLE = "default"
THEME_TEMPLATES_OVERRIDES = ["theme/Flex-extend/templates"]
THEME_STATIC_PATHS = ["static", "../Flex-extend/static"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
THEME_STATIC_PATHS = ["static", "../Flex-extend/static"]
THEME_STATIC_PATHS = ["../Flex-extend/static"]

Just tested locally. we might not need static here

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the review is addressed. I think we're good to merge this one

@winniepopu winniepopu merged commit 27ebc52 into pycontw:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants