Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for step #227

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add support for step #227

wants to merge 6 commits into from

Conversation

rgimen3z
Copy link
Contributor

Add support for step in number types.

Fixes #132.

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

sydney-runkle
sydney-runkle requested changes May 30, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall, but I think we should do some more thorough testing!

src/python-fastui/fastui/json_schema.py Outdated Show resolved Hide resolved
src/python-fastui/tests/test_forms.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle Awaiting requested review from sydney-runkle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModelForm float fields are forced to take values +/- 1 from the current value
2 participants
@rgimen3z @sydney-runkle