Improve documentation and add default to ConstantUnhandledPredicatehook #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/unhandled_hook
branch
from
00e6686
to
e8dba08
Compare
alamb
commented
Oct 11, 2024
| #[derive(Debug, Clone)] | ||
| struct ConstantUnhandledPredicateHook { | ||
| default: Arc<dyn PhysicalExpr>, | ||
| } | ||
|
|
||
| impl Default for ConstantUnhandledPredicateHook { |
There was a problem hiding this comment.
I felt like using Default was more standard than a function
adriangb
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets apache#12850 from @adriangb
Here are some small API suggestions to improve the documentation and the creation of the default hook