Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct PyO3 feature usage #126

Merged
merged 1 commit into from
Aug 8, 2024
Merged

correct PyO3 feature usage #126

merged 1 commit into from
Aug 8, 2024

Conversation

davidhewitt
Copy link
Collaborator

Should fix #125

Copy link

codspeed-hq bot commented Aug 2, 2024

CodSpeed Performance Report

Merging #126 will not alter performance

Comparing pyo3-features (3233d3d) with main (8cd4497)

Summary

✅ 73 untouched benchmarks

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (8cd4497) to head (3233d3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files          12       12           
  Lines        1910     1910           
=======================================
  Hits         1813     1813           
  Misses         97       97           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd4497...3233d3d. Read the comment docs.

@samuelcolvin
Copy link
Member

Thanks so much, I'll fix up and merge soon.

@samuelcolvin samuelcolvin enabled auto-merge (squash) August 8, 2024 17:50
@samuelcolvin samuelcolvin merged commit eccf28e into main Aug 8, 2024
22 checks passed
@samuelcolvin samuelcolvin deleted the pyo3-features branch August 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jiter does not compile with the python feature
2 participants