Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo vendor of jiter crates #149

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Oct 8, 2024

Declare all extension module features in Cargo.toml, so they are visible to cargo vendor. Otherwise vendoring does not include additional dependencies like python3-dll-a and offline build fails.

Fixes: #148

Declare all extension module features in `Cargo.toml`, so they are
visible to `cargo vendor`. Otherwise vendoring does not include
additional dependencies like `python3-dll-a` and offline build fails.

Fixes: pydantic#148
Signed-off-by: Christian Heimes <christian@python.org>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (c6fe082) to head (b91d1b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          12       12           
  Lines        2042     2042           
  Branches     2042     2042           
=======================================
  Hits         1857     1857           
  Misses        112      112           
  Partials       73       73           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6fe082...b91d1b8. Read the comment docs.

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #149 will not alter performance

Comparing tiran:fix-vendor (b91d1b8) with main (c6fe082)

Summary

✅ 73 untouched benchmarks

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the broken build!

@davidhewitt davidhewitt merged commit 0276e15 into pydantic:main Oct 8, 2024
24 checks passed
@tiran tiran deleted the fix-vendor branch October 8, 2024 07:26
@tiran
Copy link
Contributor Author

tiran commented Oct 8, 2024

@davidhewitt No problem, Fromager builds cheese wheels in peculiar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyo3/generate-import-lib breaks cargo vendor and offline build
2 participants