Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simplify jobs, fix coverage #161

Merged
merged 4 commits into from
Nov 6, 2024
Merged

ci: simplify jobs, fix coverage #161

merged 4 commits into from
Nov 6, 2024

Conversation

davidhewitt
Copy link
Collaborator

  • merge macos and linux job definitions
  • use more dtolnay/rust-toolchain instead of moonrepo/setup-rust for consistency
  • use cargo-llvm-cov instead of coverage-prepare

Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #161 will improve performances by 10.29%

Comparing dh/ci-cleanups (3497a46) with main (a004d5f)

Summary

⚡ 1 improvements
✅ 72 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/ci-cleanups Change
unicode_jiter_iter 8.4 µs 7.6 µs +10.29%

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (a004d5f) to head (67887ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   91.90%   91.06%   -0.85%     
==========================================
  Files          12       12              
  Lines        2138     2138              
  Branches     2138     2138              
==========================================
- Hits         1965     1947      -18     
  Misses        109      109              
- Partials       64       82      +18     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a004d5f...67887ec. Read the comment docs.

@davidhewitt davidhewitt merged commit cf80fbb into main Nov 6, 2024
53 checks passed
@davidhewitt davidhewitt deleted the dh/ci-cleanups branch November 6, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant