Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JsonValue allow_partial to use PartialMode #163

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

samuelcolvin
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (cf80fbb) to head (5770671).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jiter/src/value.rs 57.14% 0 Missing and 15 partials ⚠️
crates/jiter/src/lib.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   91.06%   91.09%   +0.02%     
==========================================
  Files          12       13       +1     
  Lines        2138     2145       +7     
  Branches     2138     2145       +7     
==========================================
+ Hits         1947     1954       +7     
  Misses        109      109              
  Partials       82       82              
Files with missing lines Coverage Δ
crates/jiter/src/jiter.rs 92.43% <100.00%> (ø)
crates/jiter/src/python.rs 94.03% <ø> (+0.04%) ⬆️
crates/jiter/src/lib.rs 93.33% <93.33%> (ø)
crates/jiter/src/value.rs 88.10% <57.14%> (+0.19%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf80fbb...5770671. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #163 will not alter performance

Comparing allow-partial-trailing-strings (5770671) with main (cf80fbb)

Summary

✅ 73 untouched benchmarks

@samuelcolvin samuelcolvin enabled auto-merge (squash) November 12, 2024 13:32
@samuelcolvin samuelcolvin merged commit 1fbdb1e into main Nov 12, 2024
21 of 22 checks passed
@samuelcolvin samuelcolvin deleted the allow-partial-trailing-strings branch November 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant