Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore pystring_ascii_new fast path, using PyO3 0.23.3 #180

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

davidhewitt
Copy link
Collaborator

Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #180 will not alter performance

Comparing dh/pyo3-test (ed8fbbd) with main (06aa3a5)

Summary

✅ 73 untouched benchmarks

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (06aa3a5) to head (ed8fbbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files          13       13           
  Lines        2206     2206           
  Branches     2206     2206           
=======================================
  Hits         1958     1958           
  Misses        153      153           
  Partials       95       95           
Files with missing lines Coverage Δ
crates/jiter/src/py_string_cache.rs 93.16% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06aa3a5...ed8fbbd. Read the comment docs.

@davidhewitt davidhewitt changed the title restore pystring_ascii_new fast path, using new PyO3 instead restore pystring_ascii_new fast path, using PyO3 0.23.3 Dec 3, 2024
@davidhewitt davidhewitt merged commit 0744102 into main Dec 3, 2024
58 checks passed
@davidhewitt davidhewitt deleted the dh/pyo3-test branch December 3, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant