Don't use include_url with Pydantic's V1 ValidationError (#184)

pydantic · May 15, 2024 · 63a9c96 · 63a9c96
1 parent 3a9c7bf
commit 63a9c96
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/logfire/_internal/main.py b/logfire/_internal/main.py
@@ -1375,7 +1375,11 @@ def _record_exception(
     attributes = {**(attributes or {})}
     if ValidationError is not None and isinstance(exception, ValidationError):
         # insert a more detailed breakdown of pydantic errors
-        err_json = exception.json(include_url=False)
+        try:
+            err_json = exception.json(include_url=False)
+        except TypeError:  # pragma: no cover
+            # pydantic v1
+            err_json = exception.json()
         span.set_attribute(ATTRIBUTES_VALIDATION_ERROR_KEY, err_json)
         attributes[ATTRIBUTES_VALIDATION_ERROR_KEY] = err_json