Update Pydantic AI integration to use opentelemtry >= 1.35

[medaminezghal]

Description

I'm trying to add this commit to Pydantic AI to be compatible with opentelemetry>=1.35 and avoid tests deprecation caused by trace_id, span_id and trace_flags as mentioned in the new version, I've also followed the deprecation rules that will be added by this commit, but I got those errors for tests.

I think something should be done to either config.py file or pydantic_ai.py file.

[alexmojaki]

Responded in https://github.com/pydantic/pydantic-ai/pull/2094/files#r2219216547

[alexmojaki]

Yes, logfire.instrument_pydantic_ai should switch to passing a LoggerProvider instead of an EventLoggerProvider. But pydantic-ai needs to work either way.

[medaminezghal]

@alexmojaki I've done when you suggest in Pydantic AI. Now I think that some changes must be done to Logfire to fix the tests.

[alexmojaki]

But pydantic-ai needs to work either way.

It needs to be able to accept an EventLoggerProvider and try getting _logger_provider from that.

[medaminezghal]

@alexmojaki You mean editing the InstrumentationSettings to accept both EventLoggerProvider and LoggerProvider?

[alexmojaki]

Yes.

[medaminezghal]

@alexmojaki Should I use event_logger_provider: LoggerProvider | EventLoggerProvider | None = None, or add another argument?

[alexmojaki]

That's perfect. And it doesn't need to support an EventLoggerProvider that doesn't have a _logger_provider attribute.

[medaminezghal]

@alexmojaki if I edit event_logger_provider = event_logger_provider or get_logger_provider() to use either get_logger_provider() or get_event_logger_provider(), the deprecation warning will return to cause error in tests.

[alexmojaki]

InstrumentationSettings doesn't need to call get_event_logger_provider(), it just needs to handle an event provider being given explicitly, as logfire does. In any case I don't know what you mean, get_event_logger_provider() doesn't produce warnings. And I'm not suggesting creating Event objects or even an EventLogger.

[medaminezghal]

@alexmojaki I'm trying with this file: instrumented.py, all the tests pass but I got some typescheck errors:

PYRIGHT_PYTHON_IGNORE_WARNINGS=1 uv run pyright
/home/medaminezghal/Documents/draft/pydantic-ai/pydantic_ai_slim/pydantic_ai/models/instrumented.py
  /home/medaminezghal/Documents/draft/pydantic-ai/pydantic_ai_slim/pydantic_ai/models/instrumented.py:178:21 - error: Argument of type "LogRecord" cannot be assigned to parameter "object" of type "Event" in function "append"
    "LogRecord" is not assignable to "Event" (reportArgumentType)
  /home/medaminezghal/Documents/draft/pydantic-ai/pydantic_ai_slim/pydantic_ai/models/instrumented.py:189:47 - error: Argument of type "LogRecord" cannot be assigned to parameter "object" of type "Event" in function "append"
    "LogRecord" is not assignable to "Event" (reportArgumentType)
  /home/medaminezghal/Documents/draft/pydantic-ai/pydantic_ai_slim/pydantic_ai/models/instrumented.py:197:27 - error: Argument of type "list[Event] | list[LogRecord]" cannot be assigned to parameter "iterable" of type "Iterable[Event]" in function "extend"
    Type "list[Event] | list[LogRecord]" is not assignable to type "Iterable[Event]"
      "list[LogRecord]" is not assignable to "Iterable[Event]"
        Type parameter "_T_co@Iterable" is covariant, but "LogRecord" is not a subtype of "Event"
          "LogRecord" is not assignable to "Event" (reportArgumentType)
  /home/medaminezghal/Documents/draft/pydantic-ai/pydantic_ai_slim/pydantic_ai/models/instrumented.py:335:33 - error: Argument of type "LogRecord" cannot be assigned to parameter "object" of type "Event" in function "append"
    "LogRecord" is not assignable to "Event" (reportArgumentType)
  /home/medaminezghal/Documents/draft/pydantic-ai/pydantic_ai_slim/pydantic_ai/models/instrumented.py:368:65 - error: Argument of type "LogRecord | Event" cannot be assigned to parameter "event" of type "Event" in function "emit"
    Type "LogRecord | Event" is not assignable to type "Event"
      "LogRecord" is not assignable to "Event" (reportArgumentType)
5 errors, 0 warnings, 0 informations 
make: *** [Makefile:49: typecheck-pyright] Error 1

[alexmojaki]

@medaminezghal this isn't working well. Please just leave most of the code as is in pydantic-ai and filter out the deprecation warnings specifically where they're emitted. I'm going to start working on supporting in the format in open-telemetry/semantic-conventions#2179 so that we can leave events behind entirely.