Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Had to install opentelemetry instrumentation packages manually for FastAPI support. #74

Closed
jimkring opened this issue May 1, 2024 · 5 comments · Fixed by #143
Closed
Assignees
Labels
FastAPI FastAPI related Question Further information is requested

Comments

@jimkring
Copy link

jimkring commented May 1, 2024

Description

I did a pip install logfire but after trying to setup integration with FastAPI I got errors that opentelemetry-instrumentation-asgi and opentelemetry-instrumentation-fastapi weren't installed.

I probably didn't follow/find the instructions to a "t". Regards,

Python, Logfire & OS Versions, related packages (not required)

No response

@jimkring jimkring added the bug Bug related to the Logfire Python SDK label May 1, 2024
@alexmojaki
Copy link
Contributor

alexmojaki commented May 1, 2024

pip install 'logfire[fastapi]'

@Kludex
Copy link
Member

Kludex commented May 2, 2024

@jimkring Is there anything else we can help, or can we close this issue?

@Kludex Kludex added Question Further information is requested FastAPI FastAPI related and removed bug Bug related to the Logfire Python SDK labels May 2, 2024
@jimkring
Copy link
Author

jimkring commented May 2, 2024

All good thanks

@jimkring jimkring closed this as completed May 2, 2024
@alexmojaki
Copy link
Contributor

Reopening because the same mistake was made in #96 (comment) so we need to show a clearer error message in these cases.

@alexmojaki alexmojaki reopened this May 5, 2024
@jimkring
Copy link
Author

jimkring commented May 5, 2024

Thanks @alexmojaki. Yes, if log fire could detect that a dependency is missing and provide a nice message on how to fix it, that would be extremely helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastAPI FastAPI related Question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants