Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when opentelemetry-instrumentation-fastapi is missing #143

Merged

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented May 7, 2024

Copy link

cloudflare-workers-and-pages bot commented May 7, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e0717a
Status: ✅  Deploy successful!
Preview URL: https://f396b04e.logfire-docs.pages.dev
Branch Preview URL: https://runtime-error-on-missing-ope.logfire-docs.pages.dev

View logs

@Kludex Kludex enabled auto-merge (squash) May 7, 2024 07:28
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Files Patch % Lines
tests/otel_integrations/test_fastapi.py 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Kludex Kludex merged commit f37e518 into main May 7, 2024
11 checks passed
@Kludex Kludex deleted the runtime-error-on-missing-opentelemetry-instrumentation-fastapi branch May 7, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Had to install opentelemetry instrumentation packages manually for FastAPI support.
1 participant