Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add psycopg in OTEL_PACKAGES and optional-dependencies #115

Conversation

Elkiwa
Copy link

@Elkiwa Elkiwa commented May 4, 2024

Close #114

  1. Add an entry in cli.py's OTEL_PACKAGES

  2. Additionally, change the optional dependency in pyproject.toml

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😁

@alexmojaki alexmojaki merged commit 90881c3 into pydantic:main May 4, 2024
12 checks passed
@Elkiwa Elkiwa deleted the fix/inspect_opentelemetry-instrumentation-psycopg branch May 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logfire inspect is missing psycopg in the report
3 participants