Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip install command printed by 'logfire inspect' easy to copy #130

Merged
merged 2 commits into from
May 6, 2024

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented May 6, 2024

Closes #126

For example, instead of printing:

To install these packages, run:

$ pip install opentelemetry-instrumentation-sqlite3 opentelemetry-instrumentation-jinja2
       opentelemetry-instrumentation-urllib opentelemetry-instrumentation-urllib3    

it now prints:

To install these packages, run:

pip install opentelemetry-instrumentation-urllib opentelemetry-instrumentation-sqlite3 opentelemetry-instrumentation-jinja2 opentelemetry-instrumentation-urllib3

i.e. the whole command is on one line, and there's no $. Now triple-clicking that line (at least in my terminals) selects the whole line for easy copy-pasting.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cloudflare-workers-and-pages bot commented May 6, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd0e26e
Status: ✅  Deploy successful!
Preview URL: https://4cfc4f6c.logfire-docs.pages.dev
Branch Preview URL: https://alex-no-wrap-inspect-pip.logfire-docs.pages.dev

View logs

@Kludex Kludex enabled auto-merge (squash) May 6, 2024 10:34
@Kludex Kludex disabled auto-merge May 6, 2024 10:34
@Kludex Kludex enabled auto-merge (squash) May 6, 2024 10:35
@Kludex Kludex merged commit 87e8a2a into main May 6, 2024
11 checks passed
@Kludex Kludex deleted the alex/no-wrap-inspect-pip branch May 6, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer a command or argument that returns only the packages listed by logfire inspect
2 participants