Add logfire.metric_gauge()
#153
Conversation
Deploying logfire-docs with
|
| Latest commit: |
8043ffe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dae51337.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-gauge-metric.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
logfire/_internal/metrics.py
Outdated
| except ImportError: # pragma: no cover | ||
| Gauge = None | ||
| GAUGE_IMPORTED = False # type: ignore |
There was a problem hiding this comment.
I don't see why this is better than Gauge = None, and it requires 2 extra type-ignores.
There was a problem hiding this comment.
It actually avoids the type ignore on the type hint of the metric_gauge method - but I just had an idea on how to avoid one more.
I'll eat and come back to this.
logfire/_internal/metrics.py
Outdated
| def create_gauge( | ||
| self, | ||
| name: str, | ||
| unit: str = '', | ||
| description: str = '', | ||
| ): # pragma: no cover | ||
| ) -> _Gauge: # pragma: no cover |
logfire/_internal/metrics.py
Outdated
| @@ -353,7 +361,7 @@ def _create_real_instrument(self, meter: Meter) -> UpDownCounter: | |||
| return meter.create_up_down_counter(self._name, self._unit, self._description) | |||
|
|
|||
|
|
|||
| if Gauge is not None: # pragma: no branch | |||
| if Gauge is not None: # pragma: no cover | |||
There was a problem hiding this comment.
My bad, I was just trying to readd what was previously there.
| from opentelemetry.metrics import _Gauge | ||
|
|
||
| Gauge = _Gauge |
There was a problem hiding this comment.
interesting, pyright treats this differently to import _Gauge as Gauge?
There was a problem hiding this comment.
I did this because we need a return type for create_gauge in this file, and without this line, Gauge can either be _Gauge or None. Since it can be either, then the type of create_gauge is wrong.
That's why the use of another variable - the type checker will know that Gauge is _Gauge.
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
|
Thanks I needed this the other day 😆 |
Checklist