Do not require project name on logfire projects use command
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
d9da401
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0bbd1d6b.logfire-docs.pages.dev |
| Branch Preview URL: | https://projects-use-not-need-projec.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Merged
|
Is it not possible to have an optional positional argument? I think |
Kludex
force-pushed
the
projects-use-not-need-project-name
branch
from
7bc1df5 to
baffa12
Compare
Kludex
force-pushed
the
projects-use-not-need-project-name
branch
from
baffa12 to
d9da401
Compare
I thought it was not... I've replaced it 👍 |
samuelcolvin
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logfire projects useshould give you a list of projects to choose from #175