Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging integrations with non-string messages #179

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented May 14, 2024

@alexmojaki alexmojaki requested a review from Kludex May 14, 2024 18:36
Copy link

cloudflare-workers-and-pages bot commented May 14, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e28b36d
Status: ✅  Deploy successful!
Preview URL: https://01c2b13b.logfire-docs.pages.dev
Branch Preview URL: https://alex-log-non-str.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexmojaki alexmojaki changed the title Fix stdlib logging integration with non-string messages Fix logging integrations with non-string messages May 16, 2024
@alexmojaki alexmojaki enabled auto-merge (squash) May 17, 2024 22:01
@alexmojaki alexmojaki merged commit 3544608 into main May 17, 2024
11 checks passed
@alexmojaki alexmojaki deleted the alex/log-non-str branch May 17, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: bad argument type for built-in operation when custom exception raised
2 participants