Retry connection errors #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Deploying logfire-docs with
|
| Latest commit: |
10c81e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8389f62.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-retry-connection-errors.logfire-docs.pages.dev |
adriangb
approved these changes
May 27, 2024
| @@ -38,7 +41,20 @@ def gen() -> Iterable[bytes]: | |||
| yield chunk | |||
|
|
|||
| request.body = gen() # type: ignore | |||
| return super().send(request, **kwargs) | |||
|
|
|||
| max_attempts = 7 | |||
There was a problem hiding this comment.
Should this be configurable in any way?
There was a problem hiding this comment.
I don't think so. Making it configurable would be painful with little benefit, and OTEL's retrying of status codes isn't configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation, I've found that neither OTEL nor
requestsdoes any retrying by default when there's a connection or timeout error while making a request.OTEL does retry on certain status codes in a way that looks sensible so I'm leaving that case as is, although it's not the kind of problem we usually see.
It's possible to configure retries with
requestsbut OTEL doesn't do so and it didn't seem easier than just coding the retries myself.