Handle and test other OpenAI/Anthropic client methods #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Deploying logfire-docs with
|
| Latest commit: |
5cb37e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://529929c0.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-other-llm-methods.logfire-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #309
User request: https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1720726405203889
Basically when an OpenAI/Anthropic client request is made to a URL that we don't specifically handle, make a generic span with the URL (which should still be somewhat useful) instead of a noisy warning log.