Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture_headers #318

Merged
merged 5 commits into from
Jul 24, 2024
Merged

capture_headers #318

merged 5 commits into from
Jul 24, 2024

Conversation

alexmojaki
Copy link
Contributor

Closes #239

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b14aae
Status: ✅  Deploy successful!
Preview URL: https://4239a1d3.logfire-docs.pages.dev
Branch Preview URL: https://alex-headers.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexmojaki alexmojaki marked this pull request as ready for review July 18, 2024 15:40
@alexmojaki alexmojaki requested a review from Kludex July 18, 2024 15:40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this page should exist anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still applies to ASGI and WSGI until we have all the instrument methods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also lets users capture specific headers instead of all of them.

@alexmojaki alexmojaki enabled auto-merge (squash) July 24, 2024 12:47
@alexmojaki alexmojaki merged commit 201994e into main Jul 24, 2024
12 checks passed
@alexmojaki alexmojaki deleted the alex/headers branch July 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collect_headers=True kwarg to instrument_<webframe>()
2 participants