Add instrument_celery method
#322
Conversation
Deploying logfire-docs with
|
| Latest commit: |
82d52b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a64bba16.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-celery-instrumentation.logfire-docs.pages.dev |
|
I don't understand how I broke the tests... 🤔 |
Kludex
force-pushed
the
add-celery-instrumentation
branch
from
3f01a65 to
69e5321
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
.github/workflows/main.yml
Outdated
| @@ -87,9 +87,52 @@ jobs: | |||
| name: coverage-${{ matrix.python-version }} | |||
| path: coverage | |||
|
|
|||
| test-integration: | |||
There was a problem hiding this comment.
i really don't like that so much has been copied here. can we just have one workflow, with separate steps for unit and integration tests?
There was a problem hiding this comment.
I think having a different job is a way to "motivate" us to write more tests like those, since it's going to eventually slow us down.
There was a problem hiding this comment.
Your complaint seems more about the amount of duplicated code, rather than the idea of having a separate flow. Which can be solved by creating a common GH action.
| @pytest.fixture(autouse=True) | ||
| def celery_worker(celery_app: Celery) -> Iterator[WorkController]: | ||
| logger = logging.getLogger() | ||
| with start_worker(celery_app, perform_ping_check=False, loglevel=logger.level) as worker: # type: ignore |
There was a problem hiding this comment.
The loglevel has a default value to ERROR, and it modifies the root logger.
This code just sets the current level.
There was a problem hiding this comment.
This comment should be in the code
No description provided.