Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle logging None with loguru #331

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Handle logging None with loguru #331

merged 2 commits into from
Jul 24, 2024

Conversation

alexmojaki
Copy link
Contributor

So that this:

from loguru import logger

import logfire

logfire.configure()

logger.add(**logfire.loguru_handler())
logger.info(None)

doesn't emit RuntimeWarning: Failed to extract info from loguru logger

@alexmojaki alexmojaki requested a review from Kludex July 24, 2024 15:23
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cloudflare-workers-and-pages bot commented Jul 24, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e06a506
Status: ✅  Deploy successful!
Preview URL: https://c0b4b144.logfire-docs.pages.dev
Branch Preview URL: https://alex-loguru-none.logfire-docs.pages.dev

View logs

@alexmojaki alexmojaki merged commit b3ca715 into main Jul 24, 2024
12 checks passed
@alexmojaki alexmojaki deleted the alex/loguru-none branch July 24, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants