Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] - Update LiteLLM Integration Docs #333

Closed
wants to merge 4 commits into from

Conversation

ishaan-jaff
Copy link

Hi i'm the LiteLLM (https://github.com/BerriAI/litellm) maintainer. Made some improvements to the doc section on using litellm with logfire

@ishaan-jaff
Copy link
Author

@Kludex @alexmojaki can I get a review on this PR ?

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c763236) to head (f4e7881).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #333   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          119       119           
  Lines         8882      8885    +3     
  Branches      1157      1159    +2     
=========================================
+ Hits          8882      8885    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki requested a review from Kludex July 26, 2024 15:01
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comments to the rest of the file. 🙏

docker run \
-v $(pwd)/litellm_config.yaml:/app/config.yaml \
-p 4000:4000 \
-e LOGFIRE_TOKEN=Kxxxxxx \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with secrets, we want to recommend this: https://docs.docker.com/build/building/secrets/

Or at least we should make sure to mention this here...

docs/integrations/third_party/litellm.md Outdated Show resolved Hide resolved
docs/integrations/third_party/litellm.md Outdated Show resolved Hide resolved
# LiteLLM
# LiteLLM Proxy Server

Use [LiteLLM Proxy](https://docs.litellm.ai/docs/simple_proxy) to Log OpenAI, Azure, Vertex, Bedrock (100+ LLMs) to Logfire
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we improve the wording a bit here? I'm unable to suggest a change, but "Log" shouldn't be uppercase, and we should have a period at the end of the sentence.

docs/integrations/third_party/litellm.md Outdated Show resolved Hide resolved
ishaan-jaff and others added 3 commits July 26, 2024 08:16
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@Kludex
Copy link
Member

Kludex commented Jul 29, 2024

Let me know when you have applied the comments @ishaan-jaff 🙏

@samuelcolvin
Copy link
Member

I thought LiteLLM was a library to give introp between different LLMs, why does it need a proxy?

@Kludex
Copy link
Member

Kludex commented Aug 7, 2024

@ishaan-jaff are you still interested here? If so, please apply comments, and reply the question above.

@Kludex
Copy link
Member

Kludex commented Sep 26, 2024

@ishaan-jaff Happy to continue this PR if you have time to reply the comments here. 🙏

For now, I'll be closing this PR.

@Kludex Kludex closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants