-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] - Update LiteLLM Integration Docs #333
Conversation
@Kludex @alexmojaki can I get a review on this PR ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 119 119
Lines 8882 8885 +3
Branches 1157 1159 +2
=========================================
+ Hits 8882 8885 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider my comments to the rest of the file. 🙏
docker run \ | ||
-v $(pwd)/litellm_config.yaml:/app/config.yaml \ | ||
-p 4000:4000 \ | ||
-e LOGFIRE_TOKEN=Kxxxxxx \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that with secrets, we want to recommend this: https://docs.docker.com/build/building/secrets/
Or at least we should make sure to mention this here...
# LiteLLM | ||
# LiteLLM Proxy Server | ||
|
||
Use [LiteLLM Proxy](https://docs.litellm.ai/docs/simple_proxy) to Log OpenAI, Azure, Vertex, Bedrock (100+ LLMs) to Logfire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve the wording a bit here? I'm unable to suggest a change, but "Log" shouldn't be uppercase, and we should have a period at the end of the sentence.
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Let me know when you have applied the comments @ishaan-jaff 🙏 |
I thought LiteLLM was a library to give introp between different LLMs, why does it need a proxy? |
@ishaan-jaff are you still interested here? If so, please apply comments, and reply the question above. |
@ishaan-jaff Happy to continue this PR if you have time to reply the comments here. 🙏 For now, I'll be closing this PR. |
Hi i'm the LiteLLM (https://github.com/BerriAI/litellm) maintainer. Made some improvements to the doc section on using litellm with logfire