Separate sending to logfire from using standard OTEL env vars #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
8d9d2c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5de418db.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-otlp-env-vars.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 123 123
Lines 9085 9177 +92
Branches 1185 1195 +10
=========================================
+ Hits 9085 9177 +92 ☔ View full report in Codecov by Sentry. |
alexmojaki
commented
Aug 5, 2024
Comment on lines
-206
to
-207
| Ensure that `preferred_temporality=logfire.METRICS_PREFERRED_TEMPORALITY` | ||
| is passed to the constructor of metric readers/exporters that accept the `preferred_temporality` argument. |
There was a problem hiding this comment.
Thinking about exporting to other backends, I realize that this is somewhat opinionated, and we shouldn't recommend it for all alternative metric readers.
Kludex
approved these changes
Aug 6, 2024
|
|
||
| Alternatively, you can use the `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT` and `OTEL_EXPORTER_OTLP_METRICS_ENDPOINT` environment variables to specify the URLs for traces and metrics separately. These URLs should include the full path, including `/v1/traces` and `/v1/metrics`. | ||
|
|
||
| The data will be encoded using Protobuf (not JSON) and sent over HTTP (not gRPC), so make sure that your backend supports this. |
There was a problem hiding this comment.
I would add an info admonition or something to catch attention here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298, based on #350 (comment)
Notable changes:
OTEL_EXPORTER_OTLP_ENDPOINTis no longer just an alternative toLOGFIRE_BASE_URL. SettingOTEL_EXPORTER_OTLP_ENDPOINT,OTEL_EXPORTER_OTLP_TRACES_ENDPOINT, and/orOTEL_EXPORTER_OTLP_METRICS_ENDPOINTwill set up appropriate exporters in addition to sending to logfire, which must be turned off separately if desired. These are basic exporters relying on OTEL defaults. In particular they don't use our custom retrying logic.OTEL_TRACES_EXPORTERto an unsupported value will silently disable the extra OTEL exporter rather than raising an error. The idea is that it's a standard variable which (1) may be set by something other than the user without them knowing, and (2) may be consumed by something other than logfire.OTEL_METRICS_EXPORTERis similarly checked, it wasn't used at all before.