Move TestExporter to avoid requiring pytest #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
fcc2106
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8bc06213.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-test-exporter.logfire-docs.pages.dev |
alexmojaki
commented
Aug 6, 2024
| @@ -75,6 +74,7 @@ | |||
| from .exporters.quiet_metrics import QuietMetricExporter | |||
| from .exporters.remove_pending import RemovePendingSpansExporter | |||
| from .exporters.tail_sampling import TailSamplingOptions, TailSamplingProcessor | |||
| from .exporters.test import TestExporter | |||
There was a problem hiding this comment.
@Kludex it's not critical but I don't know why there isn't a stub for exporters.test when I run rye run generate-stubs. There's other stubs in the exporters folder.
There was a problem hiding this comment.
I think it's because the testing module is not in the __init__.py.
There was a problem hiding this comment.
I'm talking about logfire._internal.exporters.test, not logfire.testing
There was a problem hiding this comment.
Ah, because we don't include private objects.
There was a problem hiding this comment.
We'd need to add --include-private on the stubgen command for it to appear, I think...
There was a problem hiding this comment.
But all the other internal exporter files are there
Kludex
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367