Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop collecting package versions #387

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Aug 20, 2024

A user report in https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1724080095886999 revealed that the big logfire.package_versions resource attribute caused errors like the following when exporting metrics to Mimir (Prometheus):

Failed to export batch code: 400, reason:�received a series whose label value length exceeds the limit, label: 'logfire_package_versions', value: '{"Babel":"2.15.0","Deprecated":"1.2.14","Django":"5.1","Flask":"3.0.3","Jinja2":"3.1.4","Markdown":"3.6","MarkupSafe":"2.1.5","PyYAML":"6.0.2","Pygments":"2.18.0","SQLAlchemy":"2.0.32","Werkzeug":"3.0' (truncated) series: 'target_info{instance="362467f7ff7c489eba331bc7d4833c79", job="unknown_service", logfire_package_versions="{\"Babel\":\"2.15.0\",\"Deprecated\":\"1.2.14\",\"Django\":\"5.1\",\"Flask\":\"3.0.3\",\"Jinja' (err-mimir-label-value-too-long). To adjust the related per-tenant limit, configure -validation.max-length-label-value, or contact your service administrator.

Package versions have caused various problems, this was the final straw. Hopefully we can revive this feature in some smarter form in the future, but for now it seems best to just drop it entirely.

Internal discussion: https://pydantic.slack.com/archives/C05AF4A4WRM/p1724084380802899

Copy link

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: eb1e271
Status: ✅  Deploy successful!
Preview URL: https://e73f9073.logfire-docs.pages.dev
Branch Preview URL: https://alex-remove-package-versions.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fe12714) to head (eb1e271).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          124       124           
  Lines         9185      9178    -7     
  Branches      1196      1196           
=========================================
- Hits          9185      9178    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki requested a review from adriangb August 20, 2024 14:01
@alexmojaki alexmojaki merged commit 181640f into main Aug 20, 2024
13 checks passed
@alexmojaki alexmojaki deleted the alex/remove-package-versions branch August 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants