Remove custom_scope_suffix parameter of Logfire.log

[alexmojaki]

Based on the script below, it's about 20% faster to use logfire.with_settings(custom_scope_suffix='my_scope') rather than logfire.log(..., custom_scope_suffix='my_scope'). That's not a huge difference, but I was expecting it to be bigger.

import time

import logfire

logfire.configure(send_to_logfire=False, console=False)

lf = logfire.with_settings(custom_scope_suffix='my_scope')
start = time.time()
for i in range(100000):
    lf.log('info', 'Hello, world!')
end = time.time()
print(end - start)

start = time.time()
for i in range(100000):
    logfire.log('info', 'Hello, world!', custom_scope_suffix='my_scope')
end = time.time()
print(end - start)

The issue with logfire.log(..., custom_scope_suffix=...) is that it creates a new tracer each time. Fortunately these tracers go into a WeakKeyDictionary so they don't stick around for long, but if this changed it could lead to a memory leak.

Besides that, custom_scope_suffix is really only for very advanced users, so no need to bloat the API docs to make it more convenient.

These aren't super strong reasons, but this seems like an improvement overall, and I'd like to make this change now before we release v1 of the SDK.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95a43d4) to head (11a587c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          130       130           
  Lines         9499      9504    +5     
  Branches      1230      1232    +2     
=========================================
+ Hits          9499      9504    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cloudflare-workers-and-pages]

Deploying logfire-docs with    Cloudflare Pages

Latest commit:	11a587c
Status:	✅  Deploy successful!
Preview URL:	https://408e03b2.logfire-docs.pages.dev
Branch Preview URL:	https://alex-custom-scope-suffix.logfire-docs.pages.dev

View logs

[linear]

PYD-1066 Logfire SDK V1