Add CodeSource parameter
#409
Conversation
Deploying logfire-docs with
|
| Latest commit: |
5cc1734
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86b1ba79.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-code-source-params.logfire-docs.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
===========================================
- Coverage 100.00% 99.93% -0.07%
===========================================
Files 128 128
Lines 9355 9380 +25
Branches 1217 1221 +4
===========================================
+ Hits 9355 9374 +19
- Misses 0 4 +4
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
| @@ -145,6 +145,15 @@ def log_level_attributes(level: LevelName | int) -> dict[str, otel_types.Attribu | |||
| RESOURCE_ATTRIBUTES_PACKAGE_VERSIONS = 'logfire.package_versions' | |||
| """Versions of installed packages, serialized as list of json objects with keys 'name' and 'version'.""" | |||
|
|
|||
| RESOURCE_ATTRIBUTES_CODE_GIT_REF = 'logfire.code.git_ref' | |||
There was a problem hiding this comment.
In general we should try following semantic conventions where they exist. With a bit of effort I found https://opentelemetry.io/docs/specs/semconv/attributes-registry/vcs/. This would be vcs.repository.ref.revision.
Just noting that, not saying we should go with this overall approach or spend time on this now.
There was a problem hiding this comment.
Ah, I didn't find it. Nice. Thanks.
There was a problem hiding this comment.
They are experimental. They are not included in the opentelemetry.semconv package yet. What should I do?
No description provided.