Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket span messages #426

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix websocket span messages #426

merged 1 commit into from
Sep 16, 2024

Conversation

alexmojaki
Copy link
Contributor

A user pointed out the websocket spans still had the route in the message, e.g. HTTP /ws/path/{param_name} instead of HTTP /ws/path/param_value.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f2093b3) to head (580acc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #426   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          130       130           
  Lines         9501      9516   +15     
  Branches      1227      1229    +2     
=========================================
+ Hits          9501      9516   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki requested a review from Kludex September 16, 2024 11:32
@alexmojaki alexmojaki merged commit 965904d into main Sep 16, 2024
13 checks passed
@alexmojaki alexmojaki deleted the alex/websocket-message branch September 16, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants