Deprecate project_name in logfire.configure(), remove old kwargs from signature
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
91148d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5cf8a242.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-cleanup-configure.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 130 130
Lines 9516 9527 +11
Branches 1229 1232 +3
=========================================
+ Hits 9516 9527 +11 ☔ View full report in Codecov by Sentry. |
Kludex
reviewed
Sep 17, 2024
| @@ -144,11 +144,14 @@ class PydanticPlugin: | |||
| """Exclude specific modules from instrumentation.""" | |||
|
|
|||
|
|
|||
| def configure( | |||
| class DeprecatedKwargs(TypedDict): | |||
| pass | |||
There was a problem hiding this comment.
By "undocumented" you mean you don't have type hints? and that's why you didn't add them here? 🤔
There was a problem hiding this comment.
yes, added a comment
Kludex
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated kwargs are now moved into
**kwargs: DeprecatedKwargsand undocumented to leave the remaining docs cleaner.Internal discussion: https://pydantic.slack.com/archives/C05AF4A4WRM/p1725302678666539