-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pydantic_plugin
in logfire.configure()
with logfire.instrument_pydantic()
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9757 9782 +25
Branches 1286 1289 +3
=========================================
+ Hits 9757 9782 +25 ☔ View full report in Codecov by Sentry. |
alexmojaki
changed the title
Replace pydantic_plugin in configure with instrument_pydantic
Replace Sep 27, 2024
pydantic_plugin
in logfire.configure()
with logfire.instrument_pydantic()
Kludex
approved these changes
Sep 27, 2024
How did you do the summary with copilot? |
…e into alex/instrument-pydantic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of
logfire.configure()
cleanup discussed here: https://pydantic.slack.com/archives/C05AF4A4WRM/p1725302678666539Copilot summary
This pull request includes significant updates to the Pydantic plugin integration and related documentation. The primary changes involve simplifying the configuration process by introducing a new
instrument_pydantic
method and deprecating the old configuration method.Documentation Updates:
docs/integrations/pydantic.md
: Updated instructions to uselogfire.instrument_pydantic
instead of thepydantic_plugin
parameter inlogfire.configure
. Added notes to clarify the new usage. [1] [2] [3]docs/integrations/third-party/mirascope.md
: Updated references to the Pydantic plugin to reflect the new configuration method. [1] [2]docs/why-logfire/pydantic.md
: Updated example code to use the newinstrument_pydantic
method. [1] [2]Codebase Simplification:
logfire-api/logfire_api/__init__.py
: Addedinstrument_pydantic
method to the API. [1] [2]logfire/__init__.py
: Addedinstrument_pydantic
method to the default Logfire instance. [1] [2]Deprecations and Removals:
logfire/_internal/config.py
: Deprecated thepydantic_plugin
argument inlogfire.configure
and updated the internal configuration handling to use the new method. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Miscellaneous:
logfire/_internal/config_params.py
: Removed unusedlru_cache
import and related code. [1] [2]logfire/_internal/main.py
: Updated imports to reflect changes in the configuration handling. [1] [2]