Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pydantic_plugin in logfire.configure() with logfire.instrument_pydantic() #453

Merged
merged 15 commits into from
Sep 27, 2024

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Sep 26, 2024

Final part of logfire.configure() cleanup discussed here: https://pydantic.slack.com/archives/C05AF4A4WRM/p1725302678666539

Copilot summary

This pull request includes significant updates to the Pydantic plugin integration and related documentation. The primary changes involve simplifying the configuration process by introducing a new instrument_pydantic method and deprecating the old configuration method.

Documentation Updates:

Codebase Simplification:

Deprecations and Removals:

Miscellaneous:

Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 889b86a
Status: ✅  Deploy successful!
Preview URL: https://ac62a707.logfire-docs.pages.dev
Branch Preview URL: https://alex-instrument-pydantic.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a996819) to head (889b86a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #453   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         9757      9782   +25     
  Branches      1286      1289    +3     
=========================================
+ Hits          9757      9782   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki changed the title Replace pydantic_plugin in configure with instrument_pydantic Replace pydantic_plugin in logfire.configure() with logfire.instrument_pydantic() Sep 27, 2024
@alexmojaki alexmojaki marked this pull request as ready for review September 27, 2024 11:00
@alexmojaki alexmojaki requested a review from Kludex September 27, 2024 11:00
@Kludex
Copy link
Member

Kludex commented Sep 27, 2024

How did you do the summary with copilot?

@alexmojaki
Copy link
Contributor Author

Screenshot 2024-09-27 at 13 02 48

@alexmojaki alexmojaki merged commit f8d4c39 into main Sep 27, 2024
15 checks passed
@alexmojaki alexmojaki deleted the alex/instrument-pydantic branch September 27, 2024 12:59
petyosi pushed a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants