Use SeededRandomIdGenerator by default to prevent interference from random.seed
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9754 9759 +5
Branches 1285 1286 +1
=========================================
+ Hits 9754 9759 +5 ☔ View full report in Codecov by Sentry. |
Deploying logfire-docs with
|
| Latest commit: |
8e5845d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e41fc2d.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-seededrandomidgenerator.logfire-docs.pages.dev |
Kludex
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437. It was closed already, but the request was reasonable, and I recently saw very different spans having the same trace and span ID in user data which was concerning. My best guess is that this was caused by a call to
random.seed, so this should prevent that.