Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #479

Merged
merged 1 commit into from
Oct 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/advanced/alternative-clients.md
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
- `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=https://logfire-api.pydantic.dev/v1/traces` for just traces
- `OTEL_EXPORTER_OTLP_METRICS_ENDPOINT=https://logfire-api.pydantic.dev/v1/metrics` for just metrics
- `OTEL_EXPORTER_OTLP_HEADERS='Authorization=your-write-token'` - see [Creating Write Tokens](./creating-write-tokens.md) to obtain a write token and replace `your-write-token` with it.
- `OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf` to export in Protobuf format over HTTP (not gRPC). The **Logfire** backend supports both Protobuf and JSON, but only over HTTP for now. Some SDKs (such as Python) already use this value as the default so setting this isn't required, but other SDKs use `grpc` as the defult.
- `OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf` to export in Protobuf format over HTTP (not gRPC). The **Logfire** backend supports both Protobuf and JSON, but only over HTTP for now. Some SDKs (such as Python) already use this value as the default so setting this isn't required, but other SDKs use `grpc` as the default.

## Example with Python

2 changes: 1 addition & 1 deletion docs/guides/advanced/creating-write-tokens.md
Original file line number Diff line number Diff line change
@@ -26,5 +26,5 @@ To do this we provide the parameter `send_to_logfire='if-token-present'` in the
If you set it to `'if-token-present'`, logfire will only send data to logfire if a write token is present in the environment variable `LOGFIRE_TOKEN` or there is a token saved locally.
If you run tests in CI no data will be sent.

You can also set the environmnet variable `LOGFIRE_SEND_TO_LOGFIRE` to configure this option.
You can also set the environment variable `LOGFIRE_SEND_TO_LOGFIRE` to configure this option.
For example, you can set it to `LOGFIRE_SEND_TO_LOGFIRE=true` in your deployed application and `LOGFIRE_SEND_TO_LOGFIRE=false` in your tests setup.
2 changes: 1 addition & 1 deletion tests/auto_trace_samples/foo.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ def gen() -> Iterator[int]:
yield from range(3)


# @instrument oerrides auto-tracing
# @instrument overrides auto-tracing
@logfire.instrument('Calling async_gen via @instrument')
async def async_gen():
def inner():
2 changes: 1 addition & 1 deletion tests/test_pydantic_plugin.py
Original file line number Diff line number Diff line change
@@ -917,7 +917,7 @@ def validate_x(cls, v: Any) -> Any:


def test_old_plugin_style(exporter: TestExporter) -> None:
# Test that plguins for the old API still work together with the logfire plugin.
# Test that plugins for the old API still work together with the logfire plugin.

events: list[str] = []