Support 'if-token-present' for env var 'LOGFIRE_SEND_TO_LOGFIRE'
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
126cdd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8d8b6495.logfire-docs.pages.dev |
| Branch Preview URL: | https://if-token-present-env-allowed.logfire-docs.pages.dev |
sydney-runkle
changed the title
'if-token-present' for env var 'LOGFIRE_SEND_TO_LOGFIRE''if-token-present' for env var 'LOGFIRE_SEND_TO_LOGFIRE'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 132 132
Lines 9945 9959 +14
Branches 1333 1338 +5
=========================================
+ Hits 9945 9959 +14 ☔ View full report in Codecov by Sentry. |
Kludex
reviewed
Oct 9, 2024
sydney-runkle
commented
Oct 9, 2024
alexmojaki
reviewed
Oct 10, 2024
alexmojaki
reviewed
Oct 10, 2024
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
|
@alexmojaki, anything else you'd like here? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441
Working on adding a test to fix coverage at the moment.