Document Code Source links #505
Conversation
Deploying logfire-docs with
|
| Latest commit: |
1afb4b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47bb9ac8.logfire-docs.pages.dev |
| Branch Preview URL: | https://document-code-source-links.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 132 132
Lines 9986 9986
Branches 1343 1343
=========================================
Hits 9986 9986 ☔ View full report in Codecov by Sentry. |
|
There's a related issue to this right? Can we link it as closing #79? |
| code_source=logfire.CodeSource( | ||
| repository='https://github.com/pydantic/logfire', | ||
| revision='main', | ||
| root_path='.', |
There was a problem hiding this comment.
Should this just be the default?
There was a problem hiding this comment.
I can change this in a future PR, but I guess it makes sense to be the default yes.
There was a problem hiding this comment.
seems like it should be optional in the data class but the frontend needs to handle defaulting to it so that the env var isn't required
There was a problem hiding this comment.
The frontend already handles it, defaulting to it.
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
Kludex
force-pushed
the
document-code-source-links
branch
from
d8d2d9f to
ed45090
Compare
If it's easier, please apply the changes that you wish. I'm okay with anything. 🙏