Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NonRecordingSpans for fastapi arguments #551

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Oct 29, 2024

Multiple redundant changes to prevent errors in the patched solve_dependencies when a trace is excluded by sampling: 2 checks for span.is_recording() and wrapping in handle_internal_errors.

Copy link

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0876614
Status: ✅  Deploy successful!
Preview URL: https://bde0389a.logfire-docs.pages.dev
Branch Preview URL: https://alex-fastapi-nonrecording.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88e4e7c) to head (0876614).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #551   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          132       132           
  Lines        10086     10095    +9     
  Branches      1364      1367    +3     
=========================================
+ Hits         10086     10095    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki merged commit eb5dd22 into main Oct 29, 2024
18 checks passed
@alexmojaki alexmojaki deleted the alex/fastapi-nonrecording branch October 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant