Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set logfire.code.work_dir resource attribute whenever other code source attributes are present #563

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

alexmojaki
Copy link
Contributor

This way logfire.code.work_dir is set when the code source is configured via the OTEL_RESOURCE_ATTRIBUTES env var instead of logfire.configure(code_source=...).

@alexmojaki alexmojaki enabled auto-merge (squash) October 31, 2024 10:21
@alexmojaki alexmojaki merged commit 0e53801 into main Oct 31, 2024
15 checks passed
@alexmojaki alexmojaki deleted the alex/code-work-dir branch October 31, 2024 10:23
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4bb8685) to head (5bf91d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #563   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines        10236     10238    +2     
  Branches      1396      1397    +1     
=========================================
+ Hits         10236     10238    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant