Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the process.pid resource attribute after os.fork() #647

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

alexmojaki
Copy link
Contributor

Something I've wanted to fix for a while, and recently I came across another forking bug which I fixed in #644 so I decided to take care of this too

@alexmojaki alexmojaki requested a review from Kludex December 5, 2024 15:44
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ceefa2) to head (32bab0d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #647   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines        10683     10684    +1     
  Branches      1466      1466           
=========================================
+ Hits         10683     10684    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32bab0d
Status: ✅  Deploy successful!
Preview URL: https://60fa8eef.logfire-docs.pages.dev
Branch Preview URL: https://alex-fork-pid.logfire-docs.pages.dev

View logs

@alexmojaki alexmojaki enabled auto-merge (squash) December 5, 2024 15:51
@alexmojaki alexmojaki merged commit 3a70878 into main Dec 5, 2024
14 checks passed
@alexmojaki alexmojaki deleted the alex/fork-pid branch December 5, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants