Support AsyncEngine to SQLAlchemy
#717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kludex
commented
Dec 23, 2024
•
Kludex
commented
- Closes async sqlalchemy engine support #713
Deploying logfire-docs with
|
| Latest commit: |
5b02c4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ca203b1.logfire-docs.pages.dev |
| Branch Preview URL: | https://support-async-engine.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 137
Lines 11031 11059 +28
Branches 1539 1546 +7
=========================================
+ Hits 11031 11059 +28 ☔ View full report in Codecov by Sentry. |
alexmojaki
approved these changes
Dec 23, 2024
Comment on lines
+383
to
+384
|
|
||
| SQLAlchemyInstrumentor().uninstrument() |
There was a problem hiding this comment.
Suggested change
| SQLAlchemyInstrumentor().uninstrument() |
There was a problem hiding this comment.
We can't, bug in OTel regarding uninstrumentation/instrumentation.
| @pytest.mark.anyio | ||
| async def test_sqlalchemy_async_instrumentation(exporter: TestExporter): | ||
| with sqlite_async_engine(Path('example.db')) as engine: | ||
| logfire.instrument_sqlalchemy(engine=engine) |
There was a problem hiding this comment.
Suggested change
| logfire.instrument_sqlalchemy(engine=engine) | |
| logfire.instrument_sqlalchemy(engine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.