Add capture_all to instrument_httpx
#753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
4db0b56
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd4f7f0d.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-capture-all.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## drop-httpx-kwargs #753 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 135 135
Lines 10907 10927 +20
Branches 1547 1552 +5
===================================================
+ Hits 10907 10927 +20 ☔ View full report in Codecov by Sentry. |
Kludex
commented
Dec 31, 2024
Comment on lines
+73
to
+75
| warn_at_user_stacklevel( | ||
| 'You should use either `capture_all` or the specific capture parameters, not both.', UserWarning | ||
| ) |
There was a problem hiding this comment.
This is better being a runtime error instead of UserWarning.
There was a problem hiding this comment.
I think a warning is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pointing to my other PR.