Skip to content

Conversation

@stevenh
Copy link
Contributor

@stevenh stevenh commented Jul 10, 2025

Skip Gemini example tests in local runs to prevent it failing when the user has gcloud configured but not with the ability to run the Gemini APIs as that prevents coverage profiles from being run when developing new features or fixing bugs.

Switch test skip from a print to pytest.skip so that its clear that the test didn't actually run.

Fixes: #2167

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Jul 10, 2025

PR Change Summary

Updated testing procedures to improve local development experience by skipping certain tests and clarifying test execution status.

  • Skipped Gemini example tests in local runs to enhance development workflow.
  • Changed test skipping method from print to pytest.skip for better clarity.
  • Modified documentation to indicate tests are for CI only.

Modified Files

  • docs/graph.md
  • docs/models/google.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Skip Gemini example tests in local runs to prevent it failing when the
user has gcloud configured but not with the ability to run the Gemini
APIs as that prevents coverage profiles from being run when developing
new features or fixing bugs.

Switch test skip from a print to pytest.skip so that its clear that the
test didn't actually run.

Fixes: pydantic#2167
@stevenh stevenh force-pushed the chore/gemini-test-skip branch from ee3a9ee to 3638656 Compare July 10, 2025 20:03
@DouweM DouweM self-assigned this Jul 10, 2025
@DouweM DouweM merged commit 9b1a89b into pydantic:main Jul 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gemini examples fail if gcloud is configured

2 participants